This repository has been archived by the owner on Jan 3, 2024. It is now read-only.
First Steps Towards Replacing sqlite_orm with sqlite_modern_cpp #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
irq0
force-pushed
the
pr/sqlite-modern-cpp
branch
5 times, most recently
from
d7a998f to
8d384d3
Compare
|
This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved |
0xavi0
previously approved these changes
Nov 13, 2023
|
@irq0 we have a conflict. Lets address that so we can merge this asap, so we can avoid recurring conflicts. |
Signed-off-by: Marcel Lauhoff <[email protected]>
irq0
force-pushed
the
pr/sqlite-modern-cpp
branch
from
8d384d3 to
dc476ff
Compare
added 2 commits
November 13, 2023 13:33
Signed-off-by: Marcel Lauhoff <[email protected]>
Convert versions listing to sqlite_modern_cpp and add all necessary type bindings (ObjectState, VersionType, ceph::real_time) Signed-off-by: Marcel Lauhoff <[email protected]>
irq0
force-pushed
the
pr/sqlite-modern-cpp
branch
from
dc476ff to
7ee657f
Compare
0xavi0
approved these changes
Nov 13, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
sqlite_modern_cppalongsidesqlite_ormas a submodule. Wrapinclude in
dbapi.hto work around it's namespacesqlitecolidingwith ours. Convert
SQLiteList::versionsand add type mappers forceph::real_time,ObjectStateandVersionTypeEpic: https://github.com/aquarist-labs/s3gw/issues/742
Issue: https://github.com/aquarist-labs/s3gw/issues/788
Contribution Guidelines
Checklist